PHP 5.4.33 patch for default_socket_timeout issues

Support/Development for PHP
jas8522
Forum User
Forum User
Posts: 52
Joined: Mon Jan 09, 2006 4:02 pm

PHP 5.4.33 patch for default_socket_timeout issues

Unread post by jas8522 »

Hey there,

A patch was applied in 5.4.33 to fix a longstanding issue with SSL socket timeout problems that inadvertently seems to have caused issues with secure IMAP connections in webmail clients like Horde and Roundcube. From what I gather from the bug report, an update for the patch was supposed to have been included before release but accidentally was not.

Details in the PHP bug report here: https://bugs.php.net/bug.php?id=41631

There seems to be a patch for it available in the bug report thread, but there isn't yet a PHP 5.4.34 release for us to easily apply to resolve the issue!

I'm hoping we might be able to have the Atomic PHP 5.4.33 RPM recompiled with the patch applied and added to the repo for easy updating.

Cheers!

Jordan
evanr76
New Forum User
New Forum User
Posts: 1
Joined: Thu Oct 09, 2014 3:53 pm
Location: San Jose

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by evanr76 »

We would also appreciate this. The regression in 5.4.33 is pretty bad and the SSL timeout behavior in 5.4.32 (and earlier) was not much better.
scott
Atomicorp Staff - Site Admin
Atomicorp Staff - Site Admin
Posts: 8330
Joined: Wed Dec 31, 1969 8:00 pm
Location: earth
Contact:

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by scott »

Unfortunately the patches up there arent applying to 5.4.33 correctly. I could use some help finding one that works, or fixing this one: https://bugs.php.net/patch-display.php? ... ion=latest
jas8522
Forum User
Forum User
Posts: 52
Joined: Mon Jan 09, 2006 4:02 pm

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by jas8522 »

scott wrote:Unfortunately the patches up there arent applying to 5.4.33 correctly. I could use some help finding one that works, or fixing this one: https://bugs.php.net/patch-display.php? ... ion=latest
It seems the PHP devs may not be patching this for 5.4.34 and instead will roll back to 5.4.32 behaviour by copying in the old xp_ssl.c file from 5.4.32:
Since 5.4 is now in security-fixes mode, and the patch for this issue that got into 5.4.33 was not good, I have reverted the 5.4 branch to its 5.4.32 status for xp_ssl.c
This is from Comment @ [2014-09-26 08:08 UTC] in the above php.net bug report.

Since the patch doesn't seem to be working, perhaps this is a good solution (or at least workaround) for an atomicorp rebuild of 5.4.33 -- essentially revert to 5.4.32 behaviour for that particular file rather than patching it.
scott
Atomicorp Staff - Site Admin
Atomicorp Staff - Site Admin
Posts: 8330
Joined: Wed Dec 31, 1969 8:00 pm
Location: earth
Contact:

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by scott »

Test build 5.4.33-38.1 is going up to atomic-testing now. Let me know if this makes any difference
jas8522
Forum User
Forum User
Posts: 52
Joined: Mon Jan 09, 2006 4:02 pm

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by jas8522 »

Did php-5.4.33-39.el6 get this patch included?

I had updated to that, but still seemed to have the same issue. So I then downgraded to this patched version in atomic-testing to resolve the problem. The testing build does, indeed, resolve the issue.

It seems the simplest solution now may be to build php 5.4.34 for release, which also has this patch / reversion included.

For those waiting, but who have updated to -39 already, this will make for a simple downgrade to the patched version:

Code: Select all

# yum downgrade php php-common php-cli php-pdo php-fpm php-mbstring php-mcrypt php-gd php-xml php-imap php-mysql php-devel --enablerepo=atomic-testing
scott
Atomicorp Staff - Site Admin
Atomicorp Staff - Site Admin
Posts: 8330
Joined: Wed Dec 31, 1969 8:00 pm
Location: earth
Contact:

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by scott »

How about the 5.4.35 packages?
jas8522
Forum User
Forum User
Posts: 52
Joined: Mon Jan 09, 2006 4:02 pm

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by jas8522 »

scott wrote:How about the 5.4.35 packages?
I would assume the same downgrade workaround that the PHP devs put in 5.4.34 would still be there in 5.4.35. When I posted that I don't think 5.4.35 had been released yet!

I don't see any builds of 5.4.35 in atomic or atomic-testing though. Is that in the works?
scott
Atomicorp Staff - Site Admin
Atomicorp Staff - Site Admin
Posts: 8330
Joined: Wed Dec 31, 1969 8:00 pm
Location: earth
Contact:

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by scott »

THey went up on monday, cache problem maybe?
jas8522
Forum User
Forum User
Posts: 52
Joined: Mon Jan 09, 2006 4:02 pm

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by jas8522 »

scott wrote:THey went up on monday, cache problem maybe?
Cleared the caches locally; still wouldn't update. So I visited the repo via browser and saw them there. Then I refreshed and they disappeared. Sometimes they're there, sometimes they're not! Is it possible one of your mirrors (the one my server seems to be preferring) is failing to copy the RPMs over?
jas8522
Forum User
Forum User
Posts: 52
Joined: Mon Jan 09, 2006 4:02 pm

Re: PHP 5.4.33 patch for default_socket_timeout issues

Unread post by jas8522 »

All appears well with 5.4.35
Post Reply